Skip to content

fix arg parsing in chat.py #1846

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 17, 2024
Merged

fix arg parsing in chat.py #1846

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions examples/scripts/chat.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@
import copy
import json
import os
import sys
import pwd
import re
import time
Expand Down Expand Up @@ -258,12 +259,11 @@ def parse_eos_tokens(tokenizer, eos_tokens, eos_token_ids):

def chat_cli():
parser = TrlParser(ChatArguments)
args = parser.parse_args_into_dataclasses()[0]
if args.config == "default":
args.config = os.path.join(os.path.dirname(__file__), "config/default_chat_config.yaml")
if args.config.lower() == "none":
args.config = None
args = parser.update_dataclasses_with_config([args])[0]

if "--config" not in sys.argv:
sys.argv.append("--config")
sys.argv.append(os.path.join(os.path.dirname(__file__), "config/default_chat_config.yaml"))
args = parser.parse_args_and_config()[0]
if args.examples is None:
args.examples = {}

Expand Down