Skip to content

Conversation

sgugger
Copy link
Collaborator

@sgugger sgugger commented Nov 30, 2020

What does this PR do?

Replaces the evaluate_during_training in examples using the Trainer (as well as integrations and tf_trainer) by the new evaluation_strategy.

Fixes #8792

@LysandreJik
Copy link
Member

Merging this because we need it for the v4.0.0, pinging @jplu so he's aware of the changes made to the TFTrainer.

@sgugger sgugger merged commit 5530299 into master Nov 30, 2020
@sgugger sgugger deleted the fix_examples_to_v4 branch November 30, 2020 16:12
LysandreJik added a commit that referenced this pull request Nov 30, 2020
* Remove deprecated `evalutate_during_training`

* Update src/transformers/training_args_tf.py

Co-authored-by: Lysandre Debut <[email protected]>

Co-authored-by: Lysandre Debut <[email protected]>
stas00 added a commit to stas00/transformers that referenced this pull request Nov 30, 2020
stas00 added a commit to stas00/transformers that referenced this pull request Dec 1, 2020
LysandreJik pushed a commit that referenced this pull request Dec 1, 2020
* restore skip

* Revert "Remove deprecated `evalutate_during_training` (#8852)"

This reverts commit 5530299.

* check that pipeline.git.base_revision is defined before proceeding

* Revert "Revert "Remove deprecated `evalutate_during_training` (#8852)""

This reverts commit dfec84d.

* check that pipeline.git.base_revision is defined before proceeding

* doc only

* doc + code

* restore

* restore

* typo
stas00 pushed a commit to stas00/transformers that referenced this pull request Dec 5, 2020
* Remove deprecated `evalutate_during_training`

* Update src/transformers/training_args_tf.py

Co-authored-by: Lysandre Debut <[email protected]>

Co-authored-by: Lysandre Debut <[email protected]>
stas00 added a commit to stas00/transformers that referenced this pull request Dec 5, 2020
* restore skip

* Revert "Remove deprecated `evalutate_during_training` (huggingface#8852)"

This reverts commit 5530299.

* check that pipeline.git.base_revision is defined before proceeding

* Revert "Revert "Remove deprecated `evalutate_during_training` (huggingface#8852)""

This reverts commit dfec84d.

* check that pipeline.git.base_revision is defined before proceeding

* doc only

* doc + code

* restore

* restore

* typo
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[finetune_trainer] --evaluate_during_training is no more

2 participants