[OPT] Fix attention scaling
#38290
Merged
[OPT] Fix attention scaling
#38290
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
zucchini-nlp
left a comment
zucchini-nlp
left a comment
There was a problem hiding this comment.
Thanks for handling it! I think we should remove query_states = self.q_proj(hidden_states) * self.scaling to be consistent. Should be equivalent imo
Contributor
Author
|
Thought it was equivalent too but sadly it's not. Learned the hard lesson with whisper 😢 |
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
zucchini-nlp
approved these changes
May 22, 2025
Member
zucchini-nlp
left a comment
zucchini-nlp
left a comment
There was a problem hiding this comment.
Wow, okee, that's sad. Can we add a comment explaining why is so? Future us won't remember and refactor it out 😆
Contributor
Author
|
Haha, yea good point. I'll add a comment ^^ |
Contributor
Author
|
Added a comment |
|
Can this also be included in the upcoming patch? It's required to pass vLLM tests |
vasqu
added
the
for patch
ArthurZucker
pushed a commit
that referenced
this pull request
May 27, 2025
ArthurZucker
pushed a commit
that referenced
this pull request
May 27, 2025
ArthurZucker
pushed a commit
that referenced
this pull request
May 27, 2025
ArthurZucker
pushed a commit
that referenced
this pull request
May 28, 2025
Collaborator
|
yes for sure |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Scaling has been applied twice to OPT. This fixes it by passing
1.0explicitly to avoid sdpa and co. to create a default scaling.Fixes #38277