[Cache] rename max_batch_size -> batch_size in compilable caches
#37389
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
WIP, see this comment
Uses
deprecate_kwargto renamemax_batch_sizetobatch_sizein all compilable caches.max_batch_sizeis a bad arg name: it implies that batch sizes smaller thanmax_batch_sizecan use the cache too, which is not the case.Note that this deprecation was started before, but we messed it up along the way:
batch_sizeinstead ofmax_batch_size#32657