Skip to content

Conversation

sshleifer
Copy link
Contributor

No description provided.

@sshleifer sshleifer changed the title Bartfp16 resolves #3117 [Bart] FP16 support resolves #3117 Mar 5, 2020
@sshleifer sshleifer linked an issue Mar 5, 2020 that may be closed by this pull request
@sshleifer sshleifer changed the title [Bart] FP16 support resolves #3117 [Bart] FP16 Support Mar 5, 2020
@sshleifer sshleifer requested a review from thomwolf March 5, 2020 18:05
@codecov-io
Copy link

codecov-io commented Mar 5, 2020

Codecov Report

Merging #3145 into master will decrease coverage by 0.06%.
The diff coverage is 66.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3145      +/-   ##
==========================================
- Coverage      78%   77.94%   -0.07%     
==========================================
  Files          98       98              
  Lines       16561    16560       -1     
==========================================
- Hits        12919    12907      -12     
- Misses       3642     3653      +11
Impacted Files Coverage Δ
src/transformers/modeling_bart.py 93.37% <66.66%> (-0.02%) ⬇️
src/transformers/modeling_tf_pytorch_utils.py 89.93% <0%> (ø) ⬆️
src/transformers/modeling_roberta.py 95.71% <0%> (ø) ⬆️
src/transformers/modeling_tf_utils.py 91.29% <0%> (-2.34%) ⬇️
src/transformers/modeling_xlnet.py 75.77% <0%> (ø) ⬆️
src/transformers/modeling_ctrl.py 98.22% <0%> (ø) ⬆️
src/transformers/modeling_openai.py 81.54% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7ac47bf...1360dac. Read the comment docs.

@sshleifer sshleifer marked this pull request as ready for review March 5, 2020 18:20
@sshleifer sshleifer requested a review from LysandreJik March 5, 2020 18:21
Copy link
Member

@LysandreJik LysandreJik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

Copy link
Member

@thomwolf thomwolf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks a lot @sshleifer!

@thomwolf thomwolf merged commit 1741d74 into huggingface:master Mar 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BART FP16
4 participants