Generate: skip tests on unsupported models instead of passing #27265
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amyeroberts
approved these changes
Nov 3, 2023
|
The documentation is not available anymore as the PR was closed or merged. |
ydshieh
reviewed
Nov 3, 2023
| self.skipTest("Won't fix: old model with unique inputs/caches/other") | ||
| if any(model_name in model_class.__name__.lower() for model_name in ["umt5"]): | ||
| return | ||
| self.skipTest("TODO: needs modeling or test input preparation fixes for compatibility") |
There was a problem hiding this comment.
This is better, but as we are in for model_class in self.all_generative_model_classes, it probably means we skip many model_class unnecessary if a previous one is skipped here.
Good to merge. I can do a follow up PR to use subTest (as an exercise for me)
There was a problem hiding this comment.
After a second look, subTest doesn't make much sense here.
EduardoPach
pushed a commit
to EduardoPach/transformers
that referenced
this pull request
Nov 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Skip tests on unsupported models instead of passing, as discussed in #25086
NOTE: I've skipped to whole test in the loop over different heads as soon as it encountered a problem because a) the reason for the skips in generate is always due to some core property of the architecture (AFAIK) b) simplicity