-
Notifications
You must be signed in to change notification settings - Fork 324
Add Dockerfile-arm64 to allow docker builds on Apple M1/M2 architecture #209
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
While it does built, it's impossible to have Metal/accelerate. I don't really see why you would use such images. Do you have a use case in mind? |
|
Hey @OlivierDehaene, Thanks for having a look, TEI is great. I'm using a local docker instance in development, while it is indeed pretty slow, it saves me from using my HF Inference Endpoints in development and incurring $$ costs, and facilitates setup with other engineers with docker-compose. Self compiling with rust as explained in the local install does indeed allow for Metal support and is much faster. Speed is not of the essence in my use case (more so ease-of-setup). Hope that helps and if you'd prefer not to merge i'm happy to close and just answer in #46. Regards. |
|
Ok that makes sense. If you can add a disclaimer in the README explaining the issue with Metal/accelerate in ARM builds that would be great! |
OlivierDehaene
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks
What does this PR do?
This PR adds a
Dockerfile-arm64that does build on M1 Macs (and potentially on M2 as well, not tested)Fixes # (issue)
Before submitting
Pull Request section?
to it if that's the case.
documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.