Applying Cargo.toml optimization options
#201
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
somehowchris
deleted the
feature/cargo-release-profile-optimization-options
branch
Narsil
pushed a commit
to huggingface/text-generation-inference
that referenced
this pull request
Apr 12, 2024
# What does this PR do? I have suggested similar changes over at huggingface/text-embeddings-inference#201. Here being my additional question, why `debug` is enabled during release building? (hence I didn't add the flag to script things) Applying the following optimizations: - `lto` (link time optimizations) over all code (including dependencies) - Using a single `codegen-unit` to apply optimizations within 1 code unit at build time ## Before submitting - [ ] This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case). - [ ] Did you read the [contributor guideline](https://github.com/huggingface/transformers/blob/main/CONTRIBUTING.md#start-contributing-pull-requests), Pull Request section? - [ ] Was this discussed/approved via a Github issue or the [forum](https://discuss.huggingface.co/)? Please add a link to it if that's the case. - [ ] Did you make sure to update the documentation with your changes? Here are the [documentation guidelines](https://github.com/huggingface/transformers/tree/main/docs), and [here are tips on formatting docstrings](https://github.com/huggingface/transformers/tree/main/docs#writing-source-documentation). - [ ] Did you write any new necessary tests? ## Who can review? Anyone in the community is free to review the PR once the tests have passed. Feel free to tag members/contributors who may be interested in your PR. @OlivierDehaene OR @Narsil
cr313
added a commit
to cr313/text-generation-inference-load-test
that referenced
this pull request
Apr 19, 2024
# What does this PR do? I have suggested similar changes over at huggingface/text-embeddings-inference#201. Here being my additional question, why `debug` is enabled during release building? (hence I didn't add the flag to script things) Applying the following optimizations: - `lto` (link time optimizations) over all code (including dependencies) - Using a single `codegen-unit` to apply optimizations within 1 code unit at build time ## Before submitting - [ ] This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case). - [ ] Did you read the [contributor guideline](https://github.com/huggingface/transformers/blob/main/CONTRIBUTING.md#start-contributing-pull-requests), Pull Request section? - [ ] Was this discussed/approved via a Github issue or the [forum](https://discuss.huggingface.co/)? Please add a link to it if that's the case. - [ ] Did you make sure to update the documentation with your changes? Here are the [documentation guidelines](https://github.com/huggingface/transformers/tree/main/docs), and [here are tips on formatting docstrings](https://github.com/huggingface/transformers/tree/main/docs#writing-source-documentation). - [ ] Did you write any new necessary tests? ## Who can review? Anyone in the community is free to review the PR once the tests have passed. Feel free to tag members/contributors who may be interested in your PR. @OlivierDehaene OR @Narsil
kdamaszk
pushed a commit
to kdamaszk/tgi-gaudi
that referenced
this pull request
Apr 29, 2024
…e#1651) # What does this PR do? I have suggested similar changes over at huggingface/text-embeddings-inference#201. Here being my additional question, why `debug` is enabled during release building? (hence I didn't add the flag to script things) Applying the following optimizations: - `lto` (link time optimizations) over all code (including dependencies) - Using a single `codegen-unit` to apply optimizations within 1 code unit at build time ## Before submitting - [ ] This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case). - [ ] Did you read the [contributor guideline](https://github.com/huggingface/transformers/blob/main/CONTRIBUTING.md#start-contributing-pull-requests), Pull Request section? - [ ] Was this discussed/approved via a Github issue or the [forum](https://discuss.huggingface.co/)? Please add a link to it if that's the case. - [ ] Did you make sure to update the documentation with your changes? Here are the [documentation guidelines](https://github.com/huggingface/transformers/tree/main/docs), and [here are tips on formatting docstrings](https://github.com/huggingface/transformers/tree/main/docs#writing-source-documentation). - [ ] Did you write any new necessary tests? ## Who can review? Anyone in the community is free to review the PR once the tests have passed. Feel free to tag members/contributors who may be interested in your PR. @OlivierDehaene OR @Narsil
Nilabhra
pushed a commit
to TII-AI-Research-Center/text-generation-inference
that referenced
this pull request
May 14, 2024
…e#1651) # What does this PR do? I have suggested similar changes over at huggingface/text-embeddings-inference#201. Here being my additional question, why `debug` is enabled during release building? (hence I didn't add the flag to script things) Applying the following optimizations: - `lto` (link time optimizations) over all code (including dependencies) - Using a single `codegen-unit` to apply optimizations within 1 code unit at build time ## Before submitting - [ ] This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case). - [ ] Did you read the [contributor guideline](https://github.com/huggingface/transformers/blob/main/CONTRIBUTING.md#start-contributing-pull-requests), Pull Request section? - [ ] Was this discussed/approved via a Github issue or the [forum](https://discuss.huggingface.co/)? Please add a link to it if that's the case. - [ ] Did you make sure to update the documentation with your changes? Here are the [documentation guidelines](https://github.com/huggingface/transformers/tree/main/docs), and [here are tips on formatting docstrings](https://github.com/huggingface/transformers/tree/main/docs#writing-source-documentation). - [ ] Did you write any new necessary tests? ## Who can review? Anyone in the community is free to review the PR once the tests have passed. Feel free to tag members/contributors who may be interested in your PR. @OlivierDehaene OR @Narsil
alfredgui2
pushed a commit
to tjluyao/kv.run
that referenced
this pull request
Jul 6, 2024
# What does this PR do? I have suggested similar changes over at huggingface/text-embeddings-inference#201. Here being my additional question, why `debug` is enabled during release building? (hence I didn't add the flag to script things) Applying the following optimizations: - `lto` (link time optimizations) over all code (including dependencies) - Using a single `codegen-unit` to apply optimizations within 1 code unit at build time ## Before submitting - [ ] This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case). - [ ] Did you read the [contributor guideline](https://github.com/huggingface/transformers/blob/main/CONTRIBUTING.md#start-contributing-pull-requests), Pull Request section? - [ ] Was this discussed/approved via a Github issue or the [forum](https://discuss.huggingface.co/)? Please add a link to it if that's the case. - [ ] Did you make sure to update the documentation with your changes? Here are the [documentation guidelines](https://github.com/huggingface/transformers/tree/main/docs), and [here are tips on formatting docstrings](https://github.com/huggingface/transformers/tree/main/docs#writing-source-documentation). - [ ] Did you write any new necessary tests? ## Who can review? Anyone in the community is free to review the PR once the tests have passed. Feel free to tag members/contributors who may be interested in your PR. @OlivierDehaene OR @Narsil
MasakiMu319
pushed a commit
to MasakiMu319/text-embeddings-inference
that referenced
this pull request
Nov 27, 2024
aagnone3
pushed a commit
to StratisLLC/hf-text-embeddings-inference
that referenced
this pull request
Dec 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hihi,
Is there are reason to why
ltowas turned off (3 years ago) and no other optimization were added for releases?What does this PR do?
Applying the following optimizations:
lto(link time optimizations) over all code (including dependencies)codegen-unitto apply optimizations within 1 code unit at build timestripoff symbols, followingdebug=0Before submitting
Pull Request section?
to it if that's the case.
documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.
@OlivierDehaene OR @Narsil