Remove aiohttp dependency #3488
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hanouticelina
approved these changes
Oct 28, 2025
Closed
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
Wauplin
added a commit
that referenced
this pull request
Oct 28, 2025
* Remove aiohttp dependency * too fast
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #3487.
In
huggingface_hubv1.0 release, we've removed our dependency onaiohttpto replace it withhttpxbut we forgot to remove it from thehuggingface_hub[inference]extra dependencies insetup.py. This PR removes it, making theinferenceextra removed as well.The internal method
_import_aiohttpbeing unused, it has been removed as well.Thanks @lahwaacz for spotting this!