[HfFileSystem] Keep cache on pickle #3443
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When pickling a HfFileSystem:
This is useful to keep the cache in multiprocessing instead of starting from scratch.
This is especially useful when streaming datasets, because this way DataLoader workers don't have to re-populate the HfFileSystem cache. This PR ensures that the worker uses the cached list of files from the main process, which avoid unnecessary /api/.../tree calls
In fact, this PR is needed for huggingface/datasets#7820 which ensures that DataLoaders don't do unnecessary requests when streaming datasets