Fix bad total size after resuming download (#3234) #3248
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DKingAlpha
force-pushed
the
bugfix-resume-dl-bad-total-size
branch
from
3d928f5 to
9b24df6
Compare
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
There was a problem hiding this comment.
Thanks @DKingAlpha, the fix looks good to me! i left two minor comments
Co-authored-by: célina <[email protected]>
|
Thanks for your CR, that makes more sense. |
hanouticelina
approved these changes
Jul 25, 2025
There was a problem hiding this comment.
Looks good to me! thanks @DKingAlpha for the contribution 🤗
hanouticelina
added a commit
that referenced
this pull request
Jul 28, 2025
* Fix bad total size after resuming download (#3234) * Apply suggestions from code review Co-authored-by: célina <[email protected]> --------- Co-authored-by: célina <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
python -m pytest tests/test_file_download.pymake qualitynot related, left untouched.