Skip to content

[vLLM Snippet] Fix escaping #952

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 7, 2024
Merged

[vLLM Snippet] Fix escaping #952

merged 1 commit into from
Oct 7, 2024

Conversation

mishig25
Copy link
Collaborator

@mishig25 mishig25 commented Oct 7, 2024

Follow up to #693

There was trailing space in vlmm snippet which made the snippet unusable. When you try the snippet, vllm server would respond with error:

mishig@machine:~$ # Call the server using curl:
curl -X POST "http://localhost:8000/v1/chat/completions" \ 
        -H "Content-Type: application/json" \ 
        --data '{
                "model": "meta-llama/Llama-3.2-3B-Instruct",
                "messages": [
                        {"role": "user", "content": "Hello!"}
                ]
        }'

{"object":"error","message":"[{'type': 'missing', 'loc': ('body',), 'msg': 'Field required', 'input': None}]","type":"BadRequestError","param":null,"code":400}curl: (3) URL using bad/illegal format or missing URL
-H: command not found
--data: command not found
mishig@machine:~$ 

Explanation: trailing space was breaking the escaping

@julien-c
Copy link
Member

julien-c commented Oct 7, 2024

thx for fixing

@mishig25 mishig25 merged commit ada8548 into main Oct 7, 2024
5 checks passed
@mishig25 mishig25 deleted the fix_vlmm_snippet branch October 7, 2024 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants