Skip to content

Rm LocalAppSnippet.setup #950

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Conversation

mishig25
Copy link
Collaborator

@mishig25 mishig25 commented Oct 6, 2024

Follow up to #778 and #942

After #942, I've realized that a better absteraction/generalisation is just to make LocalAppSnippet.content: string | string[] & remove LocalAppSnippet.setup altogether. Instead put what was in LocalAppSnippet.setup as the first item in LocalAppSnippet.content string array

Copy link
Member

@Vaibhavs10 Vaibhavs10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No strong feelings but I do have a preference for explicit declerations over implicit.

Could we maybe add a comment in code here/ somewhere that the first line corresponds to setup? - We get a few contributors for LocalApps now, it'd be good to make it easier for them to understand.

@ngxson
Copy link
Member

ngxson commented Oct 7, 2024

In fact, my initial idea was to have the ability to hide the setup section if user already installed the package. It will be useful if the setup is multi-steps, so user can optionally hide it to gain some space.

Also agree with @Vaibhavs10 that explicitly having setup is more intuitive for contributors.

@julien-c
Copy link
Member

julien-c commented Oct 7, 2024

yes let's keep it imo

@mishig25 mishig25 closed this Oct 7, 2024
@mishig25 mishig25 deleted the remove_LocalAppSnippet_setup branch October 7, 2024 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants