-
Notifications
You must be signed in to change notification settings - Fork 539
More python inference snippets #1028
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
#1046 is merged. What does it mean for this PR? |
|
@mishig25 I took care of merging + switching test to the "new" system + fixing a snippet template. Should be all good for review now :) Note that I have added tests only for the Python snippets since I only touched these (JS/curl might be good but prefer to do them in a later PR if relevant) |
|
What's the status on this? |
coyotte508
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🙈
|
Thanks for the ping @coyotte508! PR is still relevant but I had to adapt some stuff to comply with new API + providers. Scope remains more or less the same. @julien-c @gary149 @SBrandeis @hanouticelina can you have a look at it and especially the generated snippets under |
hanouticelina
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the generated snippets look good to me 👍 left one small comment though
|
Merging as already approved + I need it for another PR I'm preparing. If you see anything that must be changed in these snippets, just comment here and I'll handle them in a separate PR. |
Given the size of the PR and the internal changes, I think it's best to review the changes commit per commit.
This PR:
I added tests for all the above.
I did not add
InferenceClientsnippets for all tasks as it's time-consuming. I only added tasks based on the trending models listed on huggingface.co/models. We might add more tasks in the future but that's less a priority.Also includes some cleaning:
"export ..."from python snippets module (6d29991)EDIT (05/03/2025): rebased from main + adapted to take providers into account. The scope of this PR is more or less the same as before.