Skip to content

[tests] make 2 tests device-agnostic #9347

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
yiyixuxu merged 2 commits into from
Sep 4, 2024
Merged

[tests] make 2 tests device-agnostic #9347

yiyixuxu merged 2 commits into from
Sep 4, 2024

Conversation

@faaany
Copy link
Contributor

@faaany faaany commented Sep 2, 2024

What does this PR do?

Hi, this PR makes 2 tests work on XPU.

pytest -rA tests/models/autoencoders/test_models_vae.py::ConsistencyDecoderVAEIntegrationTests::test_encode_decode
pytest -rA tests/models/autoencoders/test_models_vae.py::ConsistencyDecoderVAEIntegrationTests::test_encode_decode_f16

Below are the results:

================================================ short test summary info =================================================
PASSED tests/models/autoencoders/test_models_vae.py::ConsistencyDecoderVAEIntegrationTests::test_encode_decode_f16
============================================= 1 passed, 2 warnings in 3.76s ==============================================
================================================ short test summary info =================================================
PASSED tests/models/autoencoders/test_models_vae.py::ConsistencyDecoderVAEIntegrationTests::test_encode_decode
============================================= 1 passed, 2 warnings in 3.77s ==============================================

@yiyixuxu and @asomoza

yiyixuxu
yiyixuxu approved these changes Sep 2, 2024
View reviewed changes
Copy link
Collaborator

@yiyixuxu yiyixuxu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@yiyixuxu
Copy link
Collaborator

yiyixuxu commented Sep 2, 2024

can you run make style and make fix-copies so the CI pass?

@faaany
Copy link
Contributor Author

faaany commented Sep 3, 2024

can you run make style and make fix-copies so the CI pass?

thanks for the quick review! reformatted.

@yiyixuxu yiyixuxu merged commit 2ee3215 into huggingface:main Sep 4, 2024
sayakpaul pushed a commit that referenced this pull request Dec 23, 2024
@faaany @sayakpaul
[tests] make 2 tests device-agnostic (#9347)
704226e 
* enabel on xpu

* fix style
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yiyixuxu yiyixuxu yiyixuxu approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@faaany @yiyixuxu