Skip to content

Conversation

@SkyTNT
Copy link
Contributor

@SkyTNT SkyTNT commented Oct 21, 2022

Hello. I add support for half-precision and fix bugs in onnx pipelines. @anton-l could you take a look here?

@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Oct 21, 2022

The documentation is not available anymore as the PR was closed or merged.

@anton-l
Copy link
Member

anton-l commented Oct 21, 2022

This looks great @SkyTNT, thank you so much!
Putting it to the top of my review list

@anton-l anton-l self-requested a review October 21, 2022 15:23
Copy link
Member

@anton-l anton-l left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work @SkyTNT! Taking a look at the batched safety checker issue, we probably have a bug in forward_onnx() that causes it.

@SkyTNT SkyTNT requested a review from anton-l October 25, 2022 14:02
Copy link
Member

@anton-l anton-l left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for the updates!

@anton-l anton-l merged commit 0b42b07 into huggingface:main Oct 25, 2022
@anton-l anton-l mentioned this pull request Nov 2, 2022
yoonseokjin pushed a commit to yoonseokjin/diffusers that referenced this pull request Dec 25, 2023
…gface#932)

* [Onnx] support half-precision and fix bugs for onnx pipelines

* Update convert_stable_diffusion_checkpoint_to_onnx.py

* style

* fix has_nsfw_concept

* Update convert_stable_diffusion_checkpoint_to_onnx.py

* fix style
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants