[CI] More fixes for Fast GPU Tests on main #9300
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sayakpaul
reviewed
Aug 28, 2024
Comment on lines
+35
to
+36
| # Skip setting testing with default: AttnProcessor | ||
| uses_custom_attn_processor = True |
Member
There was a problem hiding this comment.
Could be added to Fal as well no?
sayakpaul
reviewed
Aug 28, 2024
| batch_params = frozenset(["prompt"]) | ||
|
|
||
| # there is no xformers processor for Flux | ||
| test_xformers_attention = False |
Member
There was a problem hiding this comment.
Where are we using this flag? Ah okay here: https://github.com/huggingface/diffusers/blob/main/tests/pipelines/test_pipelines_common.py.
sayakpaul
approved these changes
Aug 28, 2024
Member
sayakpaul
left a comment
sayakpaul
left a comment
There was a problem hiding this comment.
LGTM. Let's make sure to not test for these cases wherever applicable. AuraFlow, for example, could be added.
sayakpaul
pushed a commit
that referenced
this pull request
Dec 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Add a check on
set_attention_processor_for_determinismtest that allows us to skip this test for models that don't use AttnProcessor or AttnProcessor_2Skip xformers tests for models/pipelines without an xformers processor.
Fixes # (issue)
Before submitting
documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.