[tests] remove/speedup some low signal tests #9285
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a-r-r-o-w
commented
Aug 27, 2024
a-r-r-o-w
commented
Aug 27, 2024
DN6
reviewed
Aug 27, 2024
| if test_mean_pixel_difference: | ||
| assert_mean_pixel_difference(output_with_offload[0], output_without_offload[0]) | ||
|
|
||
| def test_progress_bar(self): |
Collaborator
There was a problem hiding this comment.
Would actually test this once. We can add it here
https://github.com/huggingface/diffusers/blob/main/tests/pipelines/test_pipeline_utils.py
Contributor
Author
|
cc @yiyixuxu since this modifies the IP adapter tests that we worked on together when they were first introduced. TLDR; combining the multi and single ip-adapter tests, and enable/disable freeu tests, saves us roughly 40-50 forward passes |
DN6
approved these changes
Aug 29, 2024
6 tasks
sayakpaul
pushed a commit
that referenced
this pull request
Dec 23, 2024
* remove 2 shapes from SDFunctionTesterMixin::test_vae_tiling * combine freeu enable/disable test to reduce many inference runs * remove low signal unet test for signature * remove low signal embeddings test * remove low signal progress bar test from PipelineTesterMixin * combine ip-adapter single and multi tests to save many inferences * fix broken tests * Update tests/pipelines/test_pipelines_common.py * Update tests/pipelines/test_pipelines_common.py * add progress bar tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
As discussed internally with @DN6.
Who can review?
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.