Reflect few contributions on contribution.md that were not reflected on #8294
#8938
Conversation
Co-authored-by: Jihun Lim <[email protected]>
Co-authored-by: Jihun Lim <[email protected]>
Co-authored-by: Jihun Lim <[email protected]>
Co-authored-by: Jihun Lim <[email protected]>
heuristicwave
left a comment
heuristicwave
left a comment
There was a problem hiding this comment.
The document was very long, so the review took a long time. Thanks to this, I was able to read the contribute document again and learn what I should take to heart.
Thank you so much for your continuous and dedicated reviews. Your feedback has been invaluable, and I truly appreciate the time and effort you've invested in. Have a nice day😊 |
Co-authored-by: Jihun Lim <[email protected]>
Co-authored-by: Jihun Lim <[email protected]>
Co-authored-by: Jihun Lim <[email protected]>
Co-authored-by: Jihun Lim <[email protected]>
Co-authored-by: Jihun Lim <[email protected]>
Co-authored-by: Jihun Lim <[email protected]>
Co-authored-by: Jihun Lim <[email protected]>
|
Hello @stevhliu 😊, may I ask for your final review of the latest changes when you have a moment? If everything looks good, I would greatly appreciate it if you could merge them. Thank you so much! 🙏 |
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
stevhliu
left a comment
stevhliu
left a comment
There was a problem hiding this comment.
Thanks for following up and completing! 🤗
…d on #8294 (#8938) * incorrect_number_fix * add_TOC * Update docs/source/ko/conceptual/contribution.md Co-authored-by: Jihun Lim <[email protected]> * Update docs/source/ko/conceptual/contribution.md Co-authored-by: Jihun Lim <[email protected]> * fix: manual edits * fix: manual edtis * fix: manual edits * Update docs/source/ko/conceptual/contribution.md Co-authored-by: Jihun Lim <[email protected]> * Update docs/source/ko/conceptual/contribution.md Co-authored-by: Jihun Lim <[email protected]> * Update docs/source/ko/conceptual/contribution.md Co-authored-by: Jihun Lim <[email protected]> * Update docs/source/ko/conceptual/contribution.md Co-authored-by: Jihun Lim <[email protected]> * Update docs/source/ko/conceptual/contribution.md Co-authored-by: Jihun Lim <[email protected]> * Update docs/source/ko/conceptual/contribution.md Co-authored-by: Jihun Lim <[email protected]> * Update docs/source/ko/conceptual/contribution.md Co-authored-by: Jihun Lim <[email protected]> * Update docs/source/ko/conceptual/contribution.md Co-authored-by: Jihun Lim <[email protected]> * Update docs/source/ko/conceptual/contribution.md Co-authored-by: Jihun Lim <[email protected]> * fix: manual edits --------- Co-authored-by: Jihun Lim <[email protected]>
4 participants
What does this PR do?
Hello!😃
As mentioned in the previous PR, this PR includes the incorporation of unaddressed contributions to
evaluation.mdandcontribution.md. Upon review, I found that all contributions were already applied toevaluation.md. For thecontribution.mdfile, I made corrections to the numbering and added a TOC as instructed in the last PR.Before submitting
documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
@heuristicwave
Thank you always for reviewing! 🤗
Best regards,
Jiwook Han