[Training] SD3 training fixes #8917
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: bghira <[email protected]>
Contributor
|
if you wanted to rewrite the formula to match that in the paper i think it's been requested and done on downstream implementations. it just reduces confusion when reading. i'm referring to the order of this statement: noisy_latents = (1.0 - sigmas) * latents + sigmas * noise
# is equal to:
# zt = (1 - texp) * x + texp * z1 |
Member
Author
|
Done 9050093 |
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
kashif
approved these changes
Jul 21, 2024
kashif
reviewed
Jul 21, 2024
Co-authored-by: Kashif Rasul <[email protected]>
Contributor
|
👍👍👍👍 |
sayakpaul
added a commit
that referenced
this pull request
Dec 23, 2024
* SD3 training fixes Co-authored-by: bghira <[email protected]> * rewrite noise addition part to respect the eqn. * styler * Update examples/dreambooth/README_sd3.md Co-authored-by: Kashif Rasul <[email protected]> --------- Co-authored-by: bghira <[email protected]> Co-authored-by: Kashif Rasul <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #8887 and #8708.
Additionally, it adds an option to control the pre-conditioning behavior on the model outputs. Multiple folks have reported that for rectified-flows we are better off without it.
@yiyixuxu for awareness.
@bghira FYI.
Pinging @haofanwang for awareness as well.