[Tests] Improve transformers model test suite coverage - Hunyuan DiT #8916
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The model use |
sayakpaul
reviewed
Jul 21, 2024
Comment on lines
42
to
43
| sequence_length = 77 | ||
| sequence_length_t5 = 256 |
There was a problem hiding this comment.
These two could be further reduced?
There was a problem hiding this comment.
I tried but it cause the tests to fail
| "sample_size": 16, | ||
| "patch_size": 2, | ||
| "in_channels": 4, | ||
| "num_layers": 2, |
There was a problem hiding this comment.
Perhaps we can fix the num_layers to 1?
… into test_model_hunyuan
4 tasks
sayakpaul
reviewed
Jul 26, 2024
| "in_channels": 4, | ||
| "num_layers": 1, | ||
| "attention_head_dim": 8, | ||
| "num_attention_heads": 3, |
There was a problem hiding this comment.
We can keep it to 2, I guess?
| "cross_attention_dim": 32, | ||
| "cross_attention_dim_t5": 32, | ||
| "pooled_projection_dim": 16, | ||
| "hidden_size": 24, |
… into test_model_hunyuan
|
Hi @sayakpaul could you help me if this PR is ok? |
|
Oh sorry. I think the PR is very nice. Will merge once the CI is green. |
sayakpaul
added a commit
that referenced
this pull request
Dec 23, 2024
…8916) * add hunyuan model test * apply suggestions * reduce dims further * reduce dims further * run make style --------- Co-authored-by: Sayak Paul <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Part of #8907
@DN6 @sayakpaul
Before submitting
documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.