Use model_info.id instead of model_info.modelId #8912
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sayakpaul
approved these changes
Jul 20, 2024
Member
sayakpaul
left a comment
sayakpaul
left a comment
There was a problem hiding this comment.
Seems like a harmless change to me.
sayakpaul
pushed a commit
that referenced
this pull request
Dec 23, 2024
Mention model_info.id instead of model_info.modelId
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to github.com/huggingface-internal/moon-landing/pull/10713 (server-side, internal link). Let's use
model_info.idinstead ofmodel.modelIdwhich is more future-proof cc @julien-c