[dreambooth] allow fine-tuning text encoder #883
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The documentation is not available anymore as the PR was closed or merged. |
Contributor
|
Cool! |
patrickvonplaten
approved these changes
Oct 17, 2022
pcuenca
approved these changes
Oct 17, 2022
| args.pretrained_model_name_or_path, unet=accelerator.unwrap_model(unet) | ||
| args.pretrained_model_name_or_path, | ||
| unet=accelerator.unwrap_model(unet), | ||
| text_encoder=accelerator.unwrap_model(text_encoder), |
Member
There was a problem hiding this comment.
This is not true when not finetuning the text encoder, is it?
Suggested change
| text_encoder=accelerator.unwrap_model(text_encoder), | |
| text_encoder=accelerator.unwrap_model(text_encoder) if args.train_text_encoder else text_encoder, |
Contributor
Author
There was a problem hiding this comment.
in that case accelerator.unwrap_model will act as a no op, so it's fine to use it like this.
Contributor
|
BTW not necessary in this PR, but it'd be very nice if we could update this table here: https://github.com/huggingface/diffusers/tree/main/examples#-diffusers-examples -> it's always nice to see directly all the examples at once. |
|
I guess this isn't compatible with deepspeed and a 8 GB GPU? |
kumquatexpress
pushed a commit
to harvestlabs/diffusers
that referenced
this pull request
Oct 19, 2022
* allow fine-tuning text encoder * fix a few things * update readme
prathikr
pushed a commit
to prathikr/diffusers
that referenced
this pull request
Oct 26, 2022
* allow fine-tuning text encoder * fix a few things * update readme
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Co-authored-by: @shirayu
Allow fine-tuning text encoder in dreambooth.