Skip to content

Fix Flax pipeline: width and height are ignored #838 #848

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
pcuenca merged 2 commits into from
Oct 14, 2022
Merged

Fix Flax pipeline: width and height are ignored #838 #848

pcuenca merged 2 commits into from
Oct 14, 2022

Conversation

@camenduru
Copy link
Contributor

@camenduru camenduru commented Oct 14, 2022

No description provided.

@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Oct 14, 2022 •
edited
Loading

The documentation is not available anymore as the PR was closed or merged.

@patrickvonplaten
Copy link
Contributor

patrickvonplaten commented Oct 14, 2022

This looks good to me ! @camenduru could you run make style once so that the quality check passes? :-)

Thanks a lot for the PR!

@pcuenca
Copy link
Member

pcuenca commented Oct 14, 2022

Thanks a lot for dealing with this! Just a couple of comments:

  • Can you please run make style to make the linter happy? (I think it wants to condense the changed block in a single line because it's short enough now). You need to install black first if you haven't done it already.
  • Every time the resolution changes triggers a recompilation of the code. Perhaps we could add a comment in the docstring for width and height about that? If you can't it's fine, we can do it in another PR :)

@camenduru
Copy link
Contributor Author

camenduru commented Oct 14, 2022

@patrickvonplaten @pcuenca thank you now I can make more cool things like this 🎉
027_0096

@pcuenca pcuenca merged commit 93a81a3 into huggingface:main Oct 14, 2022
@camenduru camenduru deleted the patch-1 branch October 15, 2022 00:50
kumquatexpress pushed a commit to harvestlabs/diffusers that referenced this pull request Oct 19, 2022
@camenduru @kumquatexpress
Fix Flax pipeline: width and height are ignored huggingface#838 (hugg…
aa96faf 
…ingface#848)

* Fix Flax pipeline: width and height are ignored huggingface#838

* Fix Flax pipeline: width and height are ignored
prathikr pushed a commit to prathikr/diffusers that referenced this pull request Oct 26, 2022
@camenduru
Fix Flax pipeline: width and height are ignored huggingface#838 (hugg…
0671472 
…ingface#848)

* Fix Flax pipeline: width and height are ignored huggingface#838

* Fix Flax pipeline: width and height are ignored
PhaneeshB pushed a commit to nod-ai/diffusers that referenced this pull request Mar 1, 2023
@powderluv
potential fix to pre-load DLL dir for torch-mlir (huggingface#848)
6c470d8 
Doesn't regress the main.py script but system already pre-loaded
the DLL so needs more testing.
PhaneeshB pushed a commit to nod-ai/diffusers that referenced this pull request Mar 1, 2023
@powderluv
Revert "potential fix to pre-load DLL dir for torch-mlir (huggingface…
f6c3112 
…#848)" (huggingface#852)

This reverts commit 6c470d8.
yoonseokjin pushed a commit to yoonseokjin/diffusers that referenced this pull request Dec 25, 2023
@camenduru
Fix Flax pipeline: width and height are ignored huggingface#838 (hugg…
a0acacc 
…ingface#848)

* Fix Flax pipeline: width and height are ignored huggingface#838

* Fix Flax pipeline: width and height are ignored
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pcuenca pcuenca pcuenca approved these changes

+1 more reviewer

@patrickvonplaten patrickvonplaten patrickvonplaten approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@camenduru @HuggingFaceDocBuilderDev @patrickvonplaten @pcuenca