🤫 Quiet IP Adapter Mask Warning #8475
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yiyixuxu
approved these changes
Jun 11, 2024
Collaborator
yiyixuxu
left a comment
yiyixuxu
left a comment
There was a problem hiding this comment.
i like this
thank you!
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
asomoza
approved these changes
Jun 11, 2024
Member
asomoza
left a comment
asomoza
left a comment
There was a problem hiding this comment.
Nice, we had this pending for some time. Thanks
Contributor
Author
Member
|
Very cool. |
Member
|
Will merge once the CI is done. There might be a single unrelated test failure which can be safely ignored. |
Contributor
Author
|
Sounds good, will follow your lead @sayakpaul , thanks! |
sayakpaul
added a commit
that referenced
this pull request
Dec 23, 2024
* quiet attn parameters * fix lint * make style && make quality --------- Co-authored-by: Sayak Paul <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #7033 and duplicate issue #7695
For testing, please follow the IP adapter masking section of the docs here. You will no longer see the warning message spam the console.
@sayakpaul @yiyixuxu @DN6 requesting review, thank you!
Before submitting
documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.