Skip to content

Conversation

@sirpaddy
Copy link
Contributor

@sirpaddy sirpaddy commented Jun 9, 2024

as the string's join method tried to join types, instead of strings

Bug that occurred:

f"Input is in incorrect format. Currently, we only support {', '.join(supported_formats)}" TypeError: sequence item 0: expected str instance, type found

What does this PR do?

Single bug fix.

Fixes # f"Input is in incorrect format. Currently, we only support {', '.join(supported_formats)}" TypeError: sequence item 0: expected str instance, type found

@sayakpaul

…tring's join method tried to join types, instead of strings

Bug that occurred:

f"Input is in incorrect format. Currently, we only support {', '.join(supported_formats)}"
TypeError: sequence item 0: expected str instance, type found
@sayakpaul sayakpaul requested a review from yiyixuxu June 10, 2024 10:31
Copy link
Collaborator

@yiyixuxu yiyixuxu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@sirpaddy
Copy link
Contributor Author

Hi @yiyixuxu, the check_code_quality-check failed (C417 Unnecessary 'map' usage (rewrite using a generator expression)). Shall I update my code accordingly and create a new PR, or how does it work?

@yiyixuxu
Copy link
Collaborator

you can just update on the same PR branch!

@sirpaddy
Copy link
Contributor Author

@yiyixuxu thanks - done!

@yiyixuxu yiyixuxu merged commit 0a1c13a into huggingface:main Jun 11, 2024
@sirpaddy sirpaddy deleted the patch-1 branch June 14, 2024 03:44
sayakpaul added a commit that referenced this pull request Dec 23, 2024
* image_processor.py: Fixed an error in ValueError's message , as the string's join method tried to join types, instead of strings

Bug that occurred:

f"Input is in incorrect format. Currently, we only support {', '.join(supported_formats)}"
TypeError: sequence item 0: expected str instance, type found

* Fixed: C417 Unnecessary `map` usage (rewrite using a generator expression)

---------

Co-authored-by: Sayak Paul <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants