-
Notifications
You must be signed in to change notification settings - Fork 6.6k
Add diffusers version and pipeline class to the Hub UA #814
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The documentation is not available anymore as the PR was closed or merged. |
| if custom_pipeline is not None: | ||
| allow_patterns += [CUSTOM_PIPELINE_FILE_NAME] | ||
|
|
||
| requested_pipeline_class = config_dict.get("_class_name", cls.__name__) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should cover all cases, right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes that'll be a very powerful metric - nice!
|
Very cool! Think the auto class we can leave out for now as we don't really have them yet. Maybe eventually we should track whether people use Passing the pipeline class is very powerful and will give us some very nice stats |
patrickvonplaten
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also would be great if @LysandreJik and/or @sgugger could take a quick look
Co-authored-by: Patrick von Platen <[email protected]>
Co-authored-by: Patrick von Platen <[email protected]>
|
I think the autoclass param sneaked in when we were copying the model loaders from transformers. Should be removed indeed :) |
|
I'm really not sure what you want me to have a look at here @patrickvonplaten . Is there a link to Transformers or Accelerate? |
LysandreJik
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! You could try using that branch to load a few models and see if you can find them in Kibana
|
Yes, got some hits! |
* Add diffusers version and pipeline class to the Hub UA * Fallback to class name for pipelines * Update src/diffusers/modeling_utils.py Co-authored-by: Patrick von Platen <[email protected]> * Update src/diffusers/modeling_flax_utils.py Co-authored-by: Patrick von Platen <[email protected]> * Remove autoclass Co-authored-by: Patrick von Platen <[email protected]>
* Add diffusers version and pipeline class to the Hub UA * Fallback to class name for pipelines * Update src/diffusers/modeling_utils.py Co-authored-by: Patrick von Platen <[email protected]> * Update src/diffusers/modeling_flax_utils.py Co-authored-by: Patrick von Platen <[email protected]> * Remove autoclass Co-authored-by: Patrick von Platen <[email protected]>
This will let us know which versions and pipelines are used the most, which in turn informs the deprecation cycles and maintenance priority. Kudos to @LysandreJik for the tip!