Skip to content

Conversation

@anton-l
Copy link
Member

@anton-l anton-l commented Oct 12, 2022

This will let us know which versions and pipelines are used the most, which in turn informs the deprecation cycles and maintenance priority. Kudos to @LysandreJik for the tip!

@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Oct 12, 2022

The documentation is not available anymore as the PR was closed or merged.

if custom_pipeline is not None:
allow_patterns += [CUSTOM_PIPELINE_FILE_NAME]

requested_pipeline_class = config_dict.get("_class_name", cls.__name__)
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should cover all cases, right?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes that'll be a very powerful metric - nice!

@patrickvonplaten
Copy link
Contributor

Very cool! Think the auto class we can leave out for now as we don't really have them yet. Maybe eventually we should track whether people use DiffusionPipeline or rather StableDiffusionPipeline, but maybe in a v2 ?

Passing the pipeline class is very powerful and will give us some very nice stats

Copy link
Contributor

@patrickvonplaten patrickvonplaten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also would be great if @LysandreJik and/or @sgugger could take a quick look

anton-l and others added 2 commits October 12, 2022 18:08
@anton-l
Copy link
Member Author

anton-l commented Oct 12, 2022

I think the autoclass param sneaked in when we were copying the model loaders from transformers. Should be removed indeed :)

@sgugger
Copy link
Contributor

sgugger commented Oct 12, 2022

I'm really not sure what you want me to have a look at here @patrickvonplaten . Is there a link to Transformers or Accelerate?

Copy link
Member

@LysandreJik LysandreJik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! You could try using that branch to load a few models and see if you can find them in Kibana

@anton-l
Copy link
Member Author

anton-l commented Oct 12, 2022

Yes, got some hits!

@anton-l anton-l merged commit 323a9e1 into main Oct 12, 2022
@anton-l anton-l deleted the add-pipelines-ua branch October 14, 2022 19:19
prathikr pushed a commit to prathikr/diffusers that referenced this pull request Oct 26, 2022
* Add diffusers version and pipeline class to the Hub UA

* Fallback to class name for pipelines

* Update src/diffusers/modeling_utils.py

Co-authored-by: Patrick von Platen <[email protected]>

* Update src/diffusers/modeling_flax_utils.py

Co-authored-by: Patrick von Platen <[email protected]>

* Remove autoclass

Co-authored-by: Patrick von Platen <[email protected]>
PhaneeshB pushed a commit to nod-ai/diffusers that referenced this pull request Mar 1, 2023
yoonseokjin pushed a commit to yoonseokjin/diffusers that referenced this pull request Dec 25, 2023
* Add diffusers version and pipeline class to the Hub UA

* Fallback to class name for pipelines

* Update src/diffusers/modeling_utils.py

Co-authored-by: Patrick von Platen <[email protected]>

* Update src/diffusers/modeling_flax_utils.py

Co-authored-by: Patrick von Platen <[email protected]>

* Remove autoclass

Co-authored-by: Patrick von Platen <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants