-
Notifications
You must be signed in to change notification settings - Fork 6.3k
[Workflows] add a workflow that can be manually triggered on a PR. #7942
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for adding this convenient GH action, LGTM. I haven't worked with GH cli but it looks very useful for this case.
required: true | ||
test_command: | ||
description: 'Test command to run (e.g.: `pytest tests/pipelines/dit/`). Any valid pytest command can be provided.' | ||
required: true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would it make sense to have a default here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think not because having a default here wouldn't really help the case IMO.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ahh this would be awesome!
…7942) * add a workflow that can be manually triggered on a PR. * remove sudo * add command * small fixes.
What does this PR do?
Currently, we manually run the SLOW tests for PRs where applicable to ensure the changed components are robust enough to merge. This is burdensome.
How about a workflow that we can trigger with a few clicks and run the desired tests within our CI runner?
This PR adds such a workflow.