Skip to content

Conversation

sayakpaul
Copy link
Member

What does this PR do?

Currently, we manually run the SLOW tests for PRs where applicable to ensure the changed components are robust enough to merge. This is burdensome.

How about a workflow that we can trigger with a few clicks and run the desired tests within our CI runner?

This PR adds such a workflow.

Copy link
Member

@BenjaminBossan BenjaminBossan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding this convenient GH action, LGTM. I haven't worked with GH cli but it looks very useful for this case.

required: true
test_command:
description: 'Test command to run (e.g.: `pytest tests/pipelines/dit/`). Any valid pytest command can be provided.'
required: true
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it make sense to have a default here?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think not because having a default here wouldn't really help the case IMO.

Copy link
Collaborator

@yiyixuxu yiyixuxu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ahh this would be awesome!

@sayakpaul sayakpaul merged commit 0f111ab into main May 15, 2024
@sayakpaul sayakpaul deleted the add-pr-test-workflow-manual branch May 15, 2024 11:49
sayakpaul added a commit that referenced this pull request Dec 23, 2024
…7942)

* add a workflow that can be manually triggered on a PR.

* remove sudo

* add command

* small fixes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants