-
Notifications
You must be signed in to change notification settings - Fork 6.6k
upgrade to python 3.10 in the Dockerfiles #7893
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
|
Hmm our base image Ubuntu makes it a little difficult to install Python 3.10. Any other ideas @DN6? |
|
Or we could follow this approach: https://github.com/huggingface/trl/blob/main/docker/trl-source-gpu/Dockerfile. I don't really mind. Let me know and I will use this PR to do that. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice. Thanks 👍🏽 Good to merge one tests pass.
|
Please see the comments first: |
* upgrade to python 3.10 * fix * try https://askubuntu.com/questions/1459694/can-not-find-python3-10-after-apt-get-installation * fix * up * yes * okay * up * up * up * up * up * check * okay * up * i[ * fix
What does this PR do?
Check here: #7703 (comment).