Skip to content

Conversation

@sayakpaul
Copy link
Member

What does this PR do?

Check here: #7703 (comment).

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@sayakpaul
Copy link
Member Author

Hmm our base image Ubuntu makes it a little difficult to install Python 3.10. Any other ideas @DN6?

@sayakpaul
Copy link
Member Author

Or we could follow this approach: https://github.com/huggingface/trl/blob/main/docker/trl-source-gpu/Dockerfile. I don't really mind. Let me know and I will use this PR to do that.

Copy link
Collaborator

@DN6 DN6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. Thanks 👍🏽 Good to merge one tests pass.

@sayakpaul
Copy link
Member Author

@sayakpaul sayakpaul merged commit 6695635 into main May 10, 2024
@sayakpaul sayakpaul deleted the update-docker-py branch May 10, 2024 12:29
sayakpaul added a commit that referenced this pull request Dec 23, 2024
* upgrade to python 3.10

* fix

* try https://askubuntu.com/questions/1459694/can-not-find-python3-10-after-apt-get-installation

* fix

* up

* yes

* okay

* up

* up

* up

* up

* up

* check

* okay

* up

* i[

* fix
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants