Skip to content

Conversation

@lawrence-cj
Copy link
Contributor

What does this PR do?

This PR adds docs for PixArtSigmaPipeline.
Cc: @sayakpaul @yiyixuxu

2. fix relative path bugs;
@lawrence-cj lawrence-cj changed the title 1. add doc for PixArtSigmaPipeline; 1. [docs] add doc for PixArtSigmaPipeline; May 4, 2024
@lawrence-cj lawrence-cj changed the title 1. [docs] add doc for PixArtSigmaPipeline; [docs] add doc for PixArtSigmaPipeline; May 4, 2024
@lawrence-cj lawrence-cj changed the title [docs] add doc for PixArtSigmaPipeline; [docs] add doc for PixArtSigmaPipeline May 4, 2024
Copy link
Member

@sayakpaul sayakpaul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you!

Copy link
Member

@stevhliu stevhliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding, remember to add the doc to the toctree!

lawrence-cj and others added 12 commits May 8, 2024 22:07
* return layer weight if not found

* better system and test

* key example and typo
…ow gated (huggingface#7880)

* 7879 - adjust documentation to use naruto dataset, since pokemon is now gated

* replace references to pokemon in docs

* more references to pokemon replaced

* Japanese translation update

---------

Co-authored-by: bghira <[email protected]>
* edited_pag_implementation

* update

---------

Co-authored-by: yiyixuxu <[email protected]>
Fix image's upcasting before `vae.encode()` when using `fp16`

Co-authored-by: YiYi Xu <[email protected]>
…ggingface#7703)

`model_output.shape` may only have rank 1.

There are warnings related to use of random keys.

```
tests/schedulers/test_scheduler_flax.py: 13 warnings
  /Users/phillypham/diffusers/src/diffusers/schedulers/scheduling_ddpm_flax.py:268: FutureWarning: normal accepts a single key, but was given a key array of shape (1, 2) != (). Use jax.vmap for batching. In a future JAX version, this will be an error.
    noise = jax.random.normal(split_key, shape=model_output.shape, dtype=self.dtype)

tests/schedulers/test_scheduler_flax.py::FlaxDDPMSchedulerTest::test_betas
  /Users/phillypham/virtualenv/diffusers/lib/python3.9/site-packages/jax/_src/random.py:731: FutureWarning: uniform accepts a single key, but was given a key array of shape (1,) != (). Use jax.vmap for batching. In a future JAX version, this will be an error.
    u = uniform(key, shape, dtype, lo, hi)  # type: ignore[arg-type]
```
Copy link
Collaborator

@yiyixuxu yiyixuxu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!
also a note, can we change the type for scheduler to KarrasDiffusionSchedulers? this here indicates that sigma pipeline only works with DPM https://github.com/lawrence-cj/diffusers/blob/d5f4c217b5f6ac4fd23b4ee627611e0fbe0707a7/src/diffusers/pipelines/pixart_alpha/pipeline_pixart_sigma.py#L191C20-L191C47

@yiyixuxu
Copy link
Collaborator

yiyixuxu commented May 9, 2024

for the failing test, can you add the new doc page here?

https://github.com/lawrence-cj/diffusers/blob/d5f4c217b5f6ac4fd23b4ee627611e0fbe0707a7/docs/source/en/_toctree.yml#L308

@lawrence-cj
Copy link
Contributor Author

thanks! also a note, can we change the type for scheduler to KarrasDiffusionSchedulers? this here indicates that sigma pipeline only works with DPM https://github.com/lawrence-cj/diffusers/blob/d5f4c217b5f6ac4fd23b4ee627611e0fbe0707a7/src/diffusers/pipelines/pixart_alpha/pipeline_pixart_sigma.py#L191C20-L191C47

Cool. Changed.

@lawrence-cj
Copy link
Contributor Author

for the failing test, can you add the new doc page here?

https://github.com/lawrence-cj/diffusers/blob/d5f4c217b5f6ac4fd23b4ee627611e0fbe0707a7/docs/source/en/_toctree.yml#L308

Fixed all the request here. Cc: @sayakpaul @yiyixuxu

@lawrence-cj lawrence-cj requested review from sayakpaul and yiyixuxu May 16, 2024 09:03
@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

Copy link
Member

@sayakpaul sayakpaul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I fixed the quality issues -- hope you don't mind.

@yiyixuxu good to merge?

@lawrence-cj
Copy link
Contributor Author

Gentle ping here. @yiyixuxu

Copy link
Collaborator

@yiyixuxu yiyixuxu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@yiyixuxu yiyixuxu merged commit 0f0defd into huggingface:main May 20, 2024
sayakpaul added a commit that referenced this pull request Dec 23, 2024
* 1. add doc for PixArtSigmaPipeline;

---------

Co-authored-by: Sayak Paul <[email protected]>
Co-authored-by: Steven Liu <[email protected]>
Co-authored-by: Guillaume LEGENDRE <[email protected]>
Co-authored-by: Álvaro Somoza <[email protected]>
Co-authored-by: Bagheera <[email protected]>
Co-authored-by: bghira <[email protected]>
Co-authored-by: Hyoungwon Cho <[email protected]>
Co-authored-by: yiyixuxu <[email protected]>
Co-authored-by: Tolga Cangöz <[email protected]>
Co-authored-by: Philip Pham <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.