adding back test_conversion_when_using_device_map #7704
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
cc @sayakpaul can you look into this why the tests still fail? it should work now with |
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
sayakpaul
reviewed
Apr 18, 2024
Comment on lines
511
to
513
| if class_name.startswith("Flax"): | ||
| raise ValueError("Flax pipelines are not supported with `device_map`.") | ||
|
|
Collaborator
Author
There was a problem hiding this comment.
just so that we can run the fast test with the tiny checkpoints
why wouldn't it work with flax pipelines?
Member
There was a problem hiding this comment.
accalerate is a Pytorch only library and we rely on accelerate for device map.
Merged
Member
yiyixuxu
force-pushed
the
fix-device-map-test
branch
from
3b24568 to
d4be522
Compare
Collaborator
Author
|
@sayakpaul |
Member
|
Do you want me to review the PR? The tests are passing. |
sayakpaul
reviewed
Apr 19, 2024
| _deps = [ | ||
| "Pillow", # keep the PIL.Image.Resampling deprecation away | ||
| "accelerate>=0.11.0", | ||
| "accelerate>=0.29.3", |
sayakpaul
added a commit
that referenced
this pull request
Dec 23, 2024
* style * Fix device map nits (#7705) --------- Co-authored-by: Sayak Paul <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
enable the
DeprecatedAttentionBlockTestsagainfollow up on #7620
we disabled the test because of this issue, which is now fixed by this PR and that's already in the latest release