[Scheduler] introduce sigma schedule. #7649
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Suraj Patil <[email protected]>
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
|
Graph of the different schedules: https://www.desmos.com/calculator/p7ow4l1dl1 |
yiyixuxu
reviewed
Apr 25, 2024
Collaborator
yiyixuxu
left a comment
yiyixuxu
left a comment
There was a problem hiding this comment.
thanks!
I left a feedback
Member
Author
|
@yiyixuxu thanks for the feedback. Just adddressed them. |
yiyixuxu
approved these changes
Apr 26, 2024
Collaborator
yiyixuxu
left a comment
yiyixuxu
left a comment
There was a problem hiding this comment.
looks good to me!
just need to update the docstring
Member
Author
|
@yiyixuxu just FYI, I have also propagated the changes to |
sayakpaul
added a commit
that referenced
this pull request
Dec 23, 2024
* introduce sigma schedule. Co-authored-by: Suraj Patil <[email protected]> * address yiyi * update docstrings. * implement the schedule for EDMDPMSolverMultistepScheduler --------- Co-authored-by: Suraj Patil <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
As discussed internally. I have only introduced the change to EDMEuler but could do it for EDMDPM too once I get an approval.