-
Notifications
You must be signed in to change notification settings - Fork 6.6k
[Model Card] standardize advanced diffusion training sdxl lora #7615
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
linoytsaban
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @chiral-carbon! same small comment from the sd15 PR, applies here too - since it can be either a LoRA or a DoRA, we need to check if the use_dora arg is True and adapt the tag accordingly :)
other than that, all good!
|
thanks @linoytsaban! have addressed the |
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
| "stable-diffusion-xl-diffusers", | ||
| "text-to-image", | ||
| "diffusers", | ||
| "lora", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
last thing 😊- we need to switch "lora" -> lora in the tags here (to use the var defined in line 114)
|
Hey @chiral-carbon! I think once we address the "lora" -> lora change it'll also pass all the tests and we can merge :) |
|
Hi @linoytsaban my apologies, I completely missed this message, will do it asap! |
e9ac47c to
276eb03
Compare
|
@linoytsaban pushed it! |
|
Thanks @chiral-carbon! I'm not sure what's failing the quality tests now 🧐 could you run make fix up please? |
|
hi @linoytsaban this is the output of it seems that it has no module named models.auto? |
|
Could you run |
85abf71 to
007afd0
Compare
|
this is the output of have pushed it as well, it changed the formatting of the |
|
should I also run |
|
hi @linoytsaban @tolgacangoz! is this PR good to be merged? |
|
It seems that there are conflicts that must be resolved. Could you resolve them? |
|
@tolgacangoz done |
|
This issue has been automatically marked as stale because it has not had recent activity. If you think this still needs to be addressed please comment on this thread. Please note that issues that do not follow the contributing guidelines are likely to be ignored. |
|
@a-r-r-o-w hi! Is this and the PR #7613 good to be merged? |
|
This issue has been automatically marked as stale because it has not had recent activity. If you think this still needs to be addressed please comment on this thread. Please note that issues that do not follow the contributing guidelines are likely to be ignored. |
|
@linoytsaban a gentle ping here |
|
This issue has been automatically marked as stale because it has not had recent activity. If you think this still needs to be addressed please comment on this thread. Please note that issues that do not follow the contributing guidelines are likely to be ignored. |
|
@sayakpaul @a-r-r-o-w @linoytsaban should I close this PR unless it is good to be merged? has been stale for a while |
|
Sorry for the delay. I'm triggering the tests again to make sure they pass and will merge once they do |
What does this PR do?
Fixes #6891 for Advanced Diffusion Training SDXL with LoRA
Notebook example: Jupyter notebook
Example model card: Model Card
Before submitting
documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
@sayakpaul @linoytsaban