Skip to content

Skip PEFT LoRA Scaling if the scale is 1.0 #7576

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sayakpaul merged 12 commits into from
Apr 11, 2024
Merged

Skip PEFT LoRA Scaling if the scale is 1.0 #7576

Changes from all commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
52e606d
Skip scaling if scale is identity
Apr 4, 2024
2a38d13
Merge branch 'main' into skip-lora-scale-if-not-necessary
sayakpaul Apr 5, 2024
800c719
move check for weight one to scale and unscale lora
Apr 5, 2024
b96f421
Merge branch 'skip-lora-scale-if-not-necessary' of https://github.com…
Apr 5, 2024
bba7838
fix code style/quality
Apr 5, 2024
b19838f
Merge branch 'main' into skip-lora-scale-if-not-necessary
sayakpaul Apr 6, 2024
067eb8e
Empty-Commit
stevenjlm Apr 6, 2024
bfdac24
Merge branch 'skip-lora-scale-if-not-necessary' of https://github.com…
stevenjlm Apr 6, 2024
d573f2a
Merge branch 'main' into skip-lora-scale-if-not-necessary
sayakpaul Apr 9, 2024
daf9557
Merge branch 'main' into skip-lora-scale-if-not-necessary
stevenjlm Apr 10, 2024
1041582
Merge branch 'skip-lora-scale-if-not-necessary' of https://github.com…
stevenjlm Apr 10, 2024
ae2910a
Merge branch 'main' into skip-lora-scale-if-not-necessary
sayakpaul Apr 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 11 additions & 3 deletions src/diffusers/utils/peft_utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,9 +64,11 @@ def recurse_remove_peft_layers(model):
module_replaced = False

if isinstance(module, LoraLayer) and isinstance(module, torch.nn.Linear):
new_module = torch.nn.Linear(module.in_features, module.out_features, bias=module.bias is not None).to(
module.weight.device
)
new_module = torch.nn.Linear(
Copy link
Member

@sayakpaul sayakpaul Apr 5, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why this change?

Copy link
Contributor Author

@stevenjlm stevenjlm Apr 5, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's the formatter, when I ran make style it made this change

Copy link
Contributor Author

@stevenjlm stevenjlm Apr 5, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you prefer if I undo it?

module.in_features,
module.out_features,
bias=module.bias is not None,
).to(module.weight.device)
new_module.weight = module.weight
if module.bias is not None:
new_module.bias = module.bias
Expand Down Expand Up @@ -110,6 +112,9 @@ def scale_lora_layers(model, weight):
"""
from peft.tuners.tuners_utils import BaseTunerLayer

if weight == 1.0:
return

for module in model.modules():
if isinstance(module, BaseTunerLayer):
module.scale_layer(weight)
Expand All @@ -129,6 +134,9 @@ def unscale_lora_layers(model, weight: Optional[float] = None):
"""
from peft.tuners.tuners_utils import BaseTunerLayer

if weight == 1.0:
return

for module in model.modules():
if isinstance(module, BaseTunerLayer):
if weight is not None and weight != 0:
Expand Down