Skip to content

Conversation

@sayakpaul
Copy link
Member

What does this PR do?

This PR makes the nightly tests workflow dispatchable. The idea is to manually trigger the torch nightly tests before making a release. The tests that are known to fail at the moment (#7334, for example) will be ignored during this check.

For releases, @DN6 and I think it's okay to just stick to the torch tests.

Once the PR is approved, will add a note in our setup.py about running this test.

Cc: @yiyixuxu for awareness.

@sayakpaul sayakpaul requested a review from DN6 April 1, 2024 07:07
Copy link
Collaborator

@DN6 DN6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 👍🏽

@sayakpaul
Copy link
Member Author

@DN6 I have added a note in setup.py about running the release tests in de550a3.

Could you take a look at it as well?

@DN6
Copy link
Collaborator

DN6 commented Apr 2, 2024

@DN6 I have added a note in setup.py about running the release tests in de550a3.

Could you take a look at it as well?

LGTM

@sayakpaul sayakpaul merged commit 5d83f50 into main Apr 2, 2024
@sayakpaul sayakpaul deleted the make-nightly-workflow-dispatchable branch April 2, 2024 06:51
noskill pushed a commit to noskill/diffusers that referenced this pull request Apr 5, 2024
* make nightly workflow dispatchable.

* add a note about running the release tests to setup.py
sayakpaul added a commit that referenced this pull request Dec 23, 2024
* make nightly workflow dispatchable.

* add a note about running the release tests to setup.py
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants