-
Notifications
You must be signed in to change notification settings - Fork 6.6k
resolve an error when floats are provided for resolution values #7537
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
|
@bghira The quality checks are likely failing because the CI message should have been more helpful here. Will take a look into it. |
|
@DN6 thanks usually i push a proposed change to get feedback before i copy to the rest. that's done now |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Good to merge once tests pass. @bghira I think you might have to run make style && make quality as well.
|
done |
|
@bghira I think some extra files got added here? The examples directory wasn't in the PR earlier? |
|
you said to run make quality |
|
should we update the dependencies |
|
i don't think there's an issue with those deps per se it's just that the main branch doesn't have the formatting the way it wanted. |
|
@bghira What version of |
|
0.3.4 |
|
Ah, diffusers Line 124 in cf6e040
Could you downgrade and run |
|
nope... that doesn't fix it. it adds even more changes |
|
thank god we tried to fix that one formatting issue, or else this PR wouldn't have 66 files with open changes :) |
|
@bghira Just a couple of pipelines that also need to be updated with the int casting. If you run |
|
@bghira If it's cool with you can I open a separate PR to get this update in and tag you as the author? There are some merge conflicts with your branch because of some recent changes to main and I think the MusicLDM pipeline also needs to have copies fixed. |
|
sure |
|
completed in #7691 |
What does this PR do?
Inside prepare_latents, it will crash if a float was inadvertently passed to the pipeline.
This will cast the input values to integers, allowing these situations to proceed.
Before submitting
documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.