-
Notifications
You must be signed in to change notification settings - Fork 6.6k
Set main_input_name in StableDiffusionSafetyChecker to "clip_input" #7500
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set main_input_name in StableDiffusionSafetyChecker to "clip_input" #7500
Conversation
FlaxStableDiffusionSafetyChecker sets main_input_name to "clip_input". This makes StableDiffusionSafetyChecker consistent.
|
Hi @clinty! Thanks for the contribution. However, I'd like to understand what purpose it serves or how you expect this to be used. Unlike in the |
|
@pcuenca only confusion on my part when I checked the value and found it to be |
|
Ah, it's set to a default value. In that case I'd support changing it to avoid confusion. I triggered a CI run, copying @sayakpaul as this affects the PyTorch implementation |
pcuenca
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM as long as tests pass.
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
|
This issue has been automatically marked as stale because it has not had recent activity. If you think this still needs to be addressed please comment on this thread. Please note that issues that do not follow the contributing guidelines are likely to be ignored. |
|
The test failure has the appearance of something transient. |
…7500) FlaxStableDiffusionSafetyChecker sets main_input_name to "clip_input". This makes StableDiffusionSafetyChecker consistent. Co-authored-by: Sayak Paul <[email protected]> Co-authored-by: YiYi Xu <[email protected]>
FlaxStableDiffusionSafetyChecker sets main_input_name to "clip_input". This makes StableDiffusionSafetyChecker consistent.