[refactor] Fix FreeInit behaviour #7410
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
DN6
reviewed
Mar 21, 2024
Collaborator
DN6
left a comment
DN6
left a comment
There was a problem hiding this comment.
LGTM. We have a failing test that needs addressing, but good to merge once fixed.
…p when fast sampling enabled
Contributor
Author
Thanks. I believe the problem occurred when |
AbhinavGopal
pushed a commit
to AbhinavGopal/diffusers
that referenced
this pull request
Mar 27, 2024
* fix freeinit impl * fix progress bar * fix progress bar and remove old code * fix num_inference_steps==1 case for freeinit by atleast running 1 step when fast sampling enabled
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes: #6874 (comment)
Also removes some of the old but unused code from FreeInit refactor.
Who can review?
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.
@DN6