Skip to content

Conversation

@AlexUmnov
Copy link
Contributor

What does this PR do?

Fixes #6906

Before submitting

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

@sayakpaul

@yiyixuxu yiyixuxu requested a review from sayakpaul February 8, 2024 20:14
Comment on lines 379 to 381
import os
from diffusers import StableDiffusionPipeline
pipe = StableDiffusionPipeline.from_pretrained(os.environ["MODEL_NAME"]).to("cuda")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's not change these things please.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can remove os, but I think it's better to switch it to StableDiffusionPipeline
It's a sd pipeline after all. And you don't need this wizardry with DPMSolverMultistepScheduler

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's okay to use DiffusionPipeline here since it's more generic. I am not sure how that is related to any wizardry.

Copy link
Member

@sayakpaul sayakpaul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Left some comments.

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@AlexUmnov
Copy link
Contributor Author

@sayakpaul let me know if you want to keep it a Diffusion pipeline instead of StableDiffusion

pipe.scheduler = DPMSolverMultistepScheduler.from_config(pipe.scheduler.config)
pipe.to("cuda")
from diffusers import StableDiffusionPipeline
pipe = StableDiffusionPipeline.from_pretrained("base-model-name").to("cuda")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
pipe = StableDiffusionPipeline.from_pretrained("base-model-name").to("cuda")
pipe = DiffusionPipeline.from_pretrained("base-model-name").to("cuda")

Copy link
Member

@sayakpaul sayakpaul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Single suggestion. After that we can merge.

@AlexUmnov
Copy link
Contributor Author

@sayakpaul

@sayakpaul
Copy link
Member

Will merge once the CI is green.

@sayakpaul sayakpaul merged commit e7696e2 into huggingface:main Feb 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

LoRA dreambooth example is broken

3 participants