Skip to content

Remove torch_dtype in to() to end deprecation #6886

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
sayakpaul merged 4 commits into from
Feb 8, 2024
Merged

Remove torch_dtype in to() to end deprecation #6886

sayakpaul merged 4 commits into from
Feb 8, 2024

Conversation

@sayakpaul
Copy link
Member

@sayakpaul sayakpaul commented Feb 7, 2024

What does this PR do?

So that part of #6885 is fixed.

@sayakpaul sayakpaul requested review from DN6 and yiyixuxu February 7, 2024 07:22
@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Feb 7, 2024

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

DN6
DN6 approved these changes Feb 7, 2024
View reviewed changes
Copy link
Collaborator

@DN6 DN6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏽

@DN6
Copy link
Collaborator

DN6 commented Feb 7, 2024

Additionally we should probably update all the docs where we pass in torch_dtype

@sayakpaul
Copy link
Member Author

sayakpaul commented Feb 7, 2024

Additionally we should probably update all the docs where we pass in torch_dtype

We cannot do that yet, because there's no deprecation behaviour in from_pretrained() for torch_dtype (both pipeline_utils.py and modeling_utils.py). So, that needs to be done first (should reside in a separate PR).

Let me know if that makes sense.

@sayakpaul sayakpaul mentioned this pull request Feb 7, 2024
Merged
@DN6
Copy link
Collaborator

DN6 commented Feb 7, 2024

So this PR is just changing all references to torch_dtype then?

@sayakpaul
Copy link
Member Author

sayakpaul commented Feb 7, 2024

Please review changes more carefully.

It’s deprecating torch_dtype inside to() along with torch_device.

@sayakpaul sayakpaul changed the title Remove torch_dtype to end deprecation Remove torch_dtype in to() to end deprecation Feb 7, 2024
@DN6
Copy link
Collaborator

DN6 commented Feb 7, 2024

Correct. But it would mean we should change all references to using to(torch_dtype= so that the slow tests will correctly set their dtypes right?

@sayakpaul
Copy link
Member Author

sayakpaul commented Feb 7, 2024

That is taken care of :-)

yiyixuxu
yiyixuxu approved these changes Feb 7, 2024
View reviewed changes
Copy link
Collaborator

@yiyixuxu yiyixuxu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you:)

@sayakpaul sayakpaul merged commit 1835510 into main Feb 8, 2024
@sayakpaul sayakpaul deleted the remove-torch-dtype branch February 8, 2024 04:09
@sayakpaul sayakpaul mentioned this pull request Feb 8, 2024
Closed
AmericanPresidentJimmyCarter pushed a commit to AmericanPresidentJimmyCarter/diffusers that referenced this pull request Apr 26, 2024
@sayakpaul
Remove torch_dtype in to() to end deprecation (huggingface#6886)
ec903e4 
* remove torch_dtype from to()

* remove torch_dtype from usage scripts.

* remove old lora backend

* Revert "remove old lora backend"

This reverts commit adcddf6.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@DN6 DN6 DN6 approved these changes

@yiyixuxu yiyixuxu yiyixuxu approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@sayakpaul @HuggingFaceDocBuilderDev @DN6 @yiyixuxu