Skip to content

Conversation

@felixsanz
Copy link
Contributor

@felixsanz felixsanz commented Feb 3, 2024

What does this PR do?

On this tutorial there is a function defined and then used inside callback_on_step_end argument, but the name was not correct (mismatch). Also the property name is num_timesteps not num_timestep.

Before submitting

Who can review?

@stevhliu, @yiyixuxu

On this tutorial there is a function defined and then used inside `callback_on_step_end` argument, but the name was not correct (mismatch)
@felixsanz felixsanz changed the title fix: callback function name is incorrect fix: typo in callback function name and propety Feb 3, 2024
@felixsanz felixsanz changed the title fix: typo in callback function name and propety fix: typo in callback function name and property Feb 3, 2024
Copy link
Member

@stevhliu stevhliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, thanks! 🤗

@stevhliu stevhliu merged commit 17612de into huggingface:main Feb 6, 2024
AmericanPresidentJimmyCarter pushed a commit to AmericanPresidentJimmyCarter/diffusers that referenced this pull request Apr 26, 2024
* fix: callback function name is incorrect

On this tutorial there is a function defined and then used inside `callback_on_step_end` argument, but the name was not correct (mismatch)

* fix: typo in num_timestep (correct is num_timesteps)

fixed property name
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants