Multiple small fixes to Video Pipeline docs #6805
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
sayakpaul
reviewed
Feb 1, 2024
|
|
||
| </Tip> | ||
|
|
||
| ## Usage example |
Member
There was a problem hiding this comment.
The usage example is already generated as a part of the pipeline call code snippet. So, this is redundant here. Until and unless there are some extended bits we wanna discuss the API spec doc should clean and lean. For detailed deep dives, having separate guides are preferable.
sayakpaul
reviewed
Feb 1, 2024
sayakpaul
reviewed
Feb 1, 2024
|
|
||
| prompt = "Spiderman is surfing" | ||
| video_frames = pipe(prompt).frames | ||
| video_frames = pipe(prompt).frames[0] |
Member
There was a problem hiding this comment.
Have we clarified about this part well enough?
sayakpaul
reviewed
Feb 1, 2024
Member
sayakpaul
left a comment
sayakpaul
left a comment
There was a problem hiding this comment.
Looking good. I think we should maybe add a separate entry in the docs somewhere for tensor2vid.
yiyixuxu
reviewed
Feb 2, 2024
Co-authored-by: YiYi Xu <[email protected]>
yiyixuxu
approved these changes
Feb 2, 2024
AmericanPresidentJimmyCarter
pushed a commit
to AmericanPresidentJimmyCarter/diffusers
that referenced
this pull request
Apr 26, 2024
* update * update * update * Update src/diffusers/pipelines/i2vgen_xl/pipeline_i2vgen_xl.py Co-authored-by: YiYi Xu <[email protected]> * update * update --------- Co-authored-by: YiYi Xu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Noticed a few small issues scattered throughout the video docs like missing example snippets, incorrect alt text etc.
This PR:
tensor_to_videxport to explicity communicate that the frames are indexed based on the batch size.Fixes # (issue)
Before submitting
documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.