Skip to content

Conversation

@stephen-iezzi
Copy link
Contributor

@stephen-iezzi stephen-iezzi commented Feb 1, 2024

What does this PR do?

Introduces Posix to provide stronger support for Windows compatibility. Changes the instance of os.path.join() to Path(...).as_posix().

Part of #6585

Before submitting

Who can review?

@sayakpaul

Copy link
Member

@sayakpaul sayakpaul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@sayakpaul
Copy link
Member

Thank you. Please ping me when the CI has completed running. I will merge.

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@stephen-iezzi
Copy link
Contributor Author

Glad to help! @sayakpaul CI is finished. 1 check failed, but it's just because of a dependency issue which is addressed in #6800.

@sayakpaul
Copy link
Member

Oops we need to run the CI one more time to mitigate the dependency bug.

@sayakpaul sayakpaul merged commit 02338c9 into huggingface:main Feb 3, 2024
AmericanPresidentJimmyCarter pushed a commit to AmericanPresidentJimmyCarter/diffusers that referenced this pull request Apr 26, 2024
change path to pathlib as_posix

Co-authored-by: Sayak Paul <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants