Skip to content

Conversation

@linoytsaban
Copy link
Collaborator

@linoytsaban linoytsaban commented Jan 24, 2024

This PR adds new features to the advanced dreambooth LoRA SDXL training script, including:

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@linoytsaban linoytsaban self-assigned this Jan 25, 2024
@linoytsaban linoytsaban marked this pull request as ready for review January 25, 2024 23:39
@linoytsaban linoytsaban changed the title [WIP] new features for the advanced dreambooth lora sdxl script [advanced dreambooth lora sdxl script] new features + bug fixes Jan 25, 2024
@linoytsaban
Copy link
Collaborator Author

@sayakpaul mind taking a look on the micro-conditioning part? :)

@linoytsaban
Copy link
Collaborator Author

linoytsaban commented Jan 31, 2024

@sayakpaul @apolinario, I think we're ready to ship 🚢 if you want take a final look :)

@linoytsaban linoytsaban requested a review from sayakpaul January 31, 2024 16:58
Copy link
Collaborator

@apolinario apolinario left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Maybe mention the blog on the top of the README.md as well?!

@linoytsaban
Copy link
Collaborator Author

Looks great! Maybe mention the blog on the top of the README.md as well?!

Thanks! done ✅

@sayakpaul
Copy link
Member

I want to take a final look after I am back. Is that okay?

Copy link
Member

@sayakpaul sayakpaul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's go 💫

@linoytsaban linoytsaban merged commit 65329ae into huggingface:main Feb 3, 2024
@linoytsaban linoytsaban deleted the advanced_script_new_features branch February 8, 2024 17:07
AmericanPresidentJimmyCarter pushed a commit to AmericanPresidentJimmyCarter/diffusers that referenced this pull request Apr 26, 2024
…ingface#6691)

* add noise_offset param

* micro conditioning - wip

* image processing adjusted and moved to support micro conditioning

* change time ids to be computed inside train loop

* change time ids to be computed inside train loop

* change time ids to be computed inside train loop

* time ids shape fix

* move token replacement of validation prompt to the same section of instance prompt and class prompt

* add offset noise to sd15 advanced script

* fix token loading during validation

* fix token loading during validation in sdxl script

* a little clean

* style

* a little clean

* style

* sdxl script - a little clean + minor path fix

sd 1.5 script - change default resolution value

* ad 1.5 script - minor path fix

* fix missing comma in code example in model card

* clean up commented lines

* style

* remove time ids computed outside training loop - no longer used now that we utilize micro-conditioning, as all time ids are now computed inside the training loop

* style

* [WIP] - added draft readme, building off of examples/dreambooth/README.md

* readme

* readme

* readme

* readme

* readme

* readme

* readme

* readme

* removed --crops_coords_top_left from CLI args

* style

* fix missing shape bug due to missing RGB if statement

* add blog mention at the start of the reamde as well

* Update examples/advanced_diffusion_training/README.md

Co-authored-by: Sayak Paul <[email protected]>

* change note to render nicely as well

---------

Co-authored-by: Sayak Paul <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants