Make Dreambooth SD Training Script torch.compile compatible
#6532
Conversation
|
@sayakpaul this is the PR for Dreambooth Regular |
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
| f.write(yaml + model_card) | ||
|
|
||
|
|
||
| def unwrap_model(accelerator, model): |
There was a problem hiding this comment.
Let's make this inside the function as done in the other PR.
There was a problem hiding this comment.
log_validation lies outside of the function. Should I put log_validation inside too?
There was a problem hiding this comment.
log_validation is fine since it's a big one. However, unwrap_model() isn't.
There was a problem hiding this comment.
log_validation uses unwrap_model too so moving unwrap_model inside the function will raise error. Do you have any idea how to fix this?
There was a problem hiding this comment.
We can pass the model to log_validation in the unwrapped state, no?
There was a problem hiding this comment.
I see. I have made new update
sayakpaul
left a comment
sayakpaul
left a comment
There was a problem hiding this comment.
Good job. Left just one comment.
sayakpaul
left a comment
sayakpaul
left a comment
There was a problem hiding this comment.
Works for me. Just comment!
Co-authored-by: Sayak Paul <[email protected]>
|
Oops. Apologies, looks like it breaks the style. Let's revert. Sorry. |
This reverts commit 70ab097.
|
No problem. I have reverted it |
|
Thanks for bearing with my requests! |
…gface#6532) * support compile * make style * move unwrap_model inside function * change unwrap call * run make style * Update examples/dreambooth/train_dreambooth.py Co-authored-by: Sayak Paul <[email protected]> * Revert "Update examples/dreambooth/train_dreambooth.py" This reverts commit 70ab097. --------- Co-authored-by: Sayak Paul <[email protected]>
3 participants
What does this PR do?
Fixes #6503
Before submitting
documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.