Skip to content

Conversation

@rootonchair
Copy link
Contributor

What does this PR do?

While working on #6360, I see that get_crop_region returns x1, y1, x2, y2 https://github.com/huggingface/diffusers/blob/main/src/diffusers/image_processor.py#L264
while apply_overlay reads it as x, y, w, h

Before submitting

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

Copy link
Collaborator

@yiyixuxu yiyixuxu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the fix!

@patrickvonplaten patrickvonplaten merged commit 79c380b into huggingface:main Jan 2, 2024
@rootonchair rootonchair deleted the fix-apply-overlay branch January 3, 2024 02:12
AmericanPresidentJimmyCarter pushed a commit to AmericanPresidentJimmyCarter/diffusers that referenced this pull request Apr 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants