[LoRA] add an error message when dealing with _best_guess_weight_name ofline #6184
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Wauplin
approved these changes
Dec 15, 2023
Collaborator
Wauplin
left a comment
Wauplin
left a comment
There was a problem hiding this comment.
Looks good to me @sayakpaul! Thanks for working on this. Agree with you that if another more complete solution already exists then let's not spend too much time maintaining this use case.
src/diffusers/loaders/lora.py
Outdated
| f for f in os.listdir(pretrained_model_name_or_path_or_dict) if f.endswith(file_extension) | ||
| ] | ||
| else: | ||
| elif not local_files_only: |
Collaborator
There was a problem hiding this comment.
I don't understand why this change. Given we raise an exception above if local_files_only is True, then it's not needed to check it here, right?
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
patrickvonplaten
approved these changes
Dec 15, 2023
donhardman
pushed a commit
to donhardman/diffusers
that referenced
this pull request
Dec 18, 2023
… ofline (huggingface#6184) * add an error message when dealing with _best_guess_weight_name ofline * simplify condition
yoonseokjin
pushed a commit
to yoonseokjin/diffusers
that referenced
this pull request
Dec 25, 2023
… ofline (huggingface#6184) * add an error message when dealing with _best_guess_weight_name ofline * simplify condition
AmericanPresidentJimmyCarter
pushed a commit
to AmericanPresidentJimmyCarter/diffusers
that referenced
this pull request
Apr 26, 2024
… ofline (huggingface#6184) * add an error message when dealing with _best_guess_weight_name ofline * simplify condition
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Potentially fixes: #6089. #6110 is related too. I decided to throw an error rather than trying to engineer a solution. I think that's best here because
_best_guess_weight_name()solves a particular use case and I don't think we should overengineer it.