Skip to content

Conversation

@yiyixuxu
Copy link
Collaborator

add image_encoder to model_cpu_offload_seq for all relevant pipelinees

@charchit7
Copy link
Contributor

@yiyixuxu any more such edit's left? Happy to help!

Copy link
Contributor

@patrickvonplaten patrickvonplaten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job! This also works just fine in case image_encoder is not defined. Can we maybe add one test?

@yiyixuxu
Copy link
Collaborator Author

@patrickvonplaten
The case where image_encoder is not defined is already tested with test_model_cpu_offload_forward_pass
I added a IP-adaper test for the case where image_encoder is defined

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@yiyixuxu yiyixuxu requested a review from sayakpaul December 15, 2023 18:41
@yiyixuxu
Copy link
Collaborator Author

cc @sayakpaul for a final review

Copy link
Member

@sayakpaul sayakpaul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@patrickvonplaten
Copy link
Contributor

Good to merge once merge conflicts are resolved here

@yiyixuxu yiyixuxu merged commit 57fde87 into main Dec 19, 2023
@yiyixuxu yiyixuxu deleted the off-load-image-encoder branch December 19, 2023 01:10
yoonseokjin pushed a commit to yoonseokjin/diffusers that referenced this pull request Dec 25, 2023
* offload image_encoder

* add test

---------

Co-authored-by: yiyixuxu <yixu310@gmail,com>
Co-authored-by: Sayak Paul <[email protected]>
donhardman pushed a commit to donhardman/diffusers that referenced this pull request Dec 29, 2023
* offload image_encoder

* add test

---------

Co-authored-by: yiyixuxu <yixu310@gmail,com>
Co-authored-by: Sayak Paul <[email protected]>
AmericanPresidentJimmyCarter pushed a commit to AmericanPresidentJimmyCarter/diffusers that referenced this pull request Apr 26, 2024
* offload image_encoder

* add test

---------

Co-authored-by: yiyixuxu <yixu310@gmail,com>
Co-authored-by: Sayak Paul <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants