Add converter method for ip adapters #6150
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
Collaborator
|
can we maybe keep this function on the same file? |
Contributor
Author
yiyixuxu
reviewed
Dec 15, 2023
src/diffusers/loaders/unet.py
Outdated
| if hasattr(self, "peft_config"): | ||
| self.peft_config.pop(adapter_name, None) | ||
|
|
||
| def _convert_ip_adapter_to_diffusers(self, state_dict): |
Collaborator
There was a problem hiding this comment.
Suggested change
| def _convert_ip_adapter_to_diffusers(self, state_dict): | |
| def _convert_ip_adapter_image_proj_to_diffusers(self, state_dict): |
Member
There was a problem hiding this comment.
I wonder if we should move this method to https://github.com/huggingface/diffusers/blob/main/src/diffusers/loaders/ip_adapter.py. This way the UNet loader stays cleaner.
src/diffusers/loaders/unet.py
Outdated
| else: | ||
| new_sd[k] = v | ||
|
|
||
| new_sd = self._convert_ip_adapter_to_diffusers(image_proj_state_dict) |
Collaborator
There was a problem hiding this comment.
can we have this function return the image_projection module instead?
sayakpaul
reviewed
Dec 16, 2023
src/diffusers/loaders/unet.py
Outdated
Comment on lines
780
to
781
| new_sd = self._convert_ip_adapter_to_diffusers(image_proj_state_dict) | ||
| image_projection.load_state_dict(new_sd) |
sayakpaul
reviewed
Dec 16, 2023
src/diffusers/loaders/unet.py
Outdated
| ) | ||
| image_projection.load_state_dict(image_proj_state_dict) | ||
| del image_proj_state_dict | ||
| new_sd = self._convert_ip_adapter_to_diffusers(image_proj_state_dict) |
Member
There was a problem hiding this comment.
Suggested change
| new_sd = self._convert_ip_adapter_to_diffusers(image_proj_state_dict) | |
| new_sd = self._convert_ip_adapter_image_proj_to_diffusers(image_proj_state_dict) |
sayakpaul
reviewed
Dec 16, 2023
src/diffusers/loaders/unet.py
Outdated
| ) | ||
| image_projection.load_state_dict(image_proj_state_dict) | ||
| del image_proj_state_dict | ||
| new_sd = self._convert_ip_adapter_to_diffusers(image_proj_state_dict) |
Member
There was a problem hiding this comment.
Suggested change
| new_sd = self._convert_ip_adapter_to_diffusers(image_proj_state_dict) | |
| new_sd = self._convert_ip_adapter_image_proj_to_diffusers(image_proj_state_dict) |
patrickvonplaten
approved these changes
Dec 18, 2023
Contributor
patrickvonplaten
left a comment
patrickvonplaten
left a comment
There was a problem hiding this comment.
Ok to merge for me once @yiyixuxu is happy with it
Contributor
Author
|
@yiyixuxu @sayakpaul @patrickvonplaten thank you for your time and digging into the code :) |
yoonseokjin
pushed a commit
to yoonseokjin/diffusers
that referenced
this pull request
Dec 25, 2023
* Add converter method for ip adapters * Move converter method * Update to image proj converter --------- Co-authored-by: Sayak Paul <[email protected]>
donhardman
pushed a commit
to donhardman/diffusers
that referenced
this pull request
Dec 29, 2023
* Add converter method for ip adapters * Move converter method * Update to image proj converter --------- Co-authored-by: Sayak Paul <[email protected]>
AmericanPresidentJimmyCarter
pushed a commit
to AmericanPresidentJimmyCarter/diffusers
that referenced
this pull request
Apr 26, 2024
* Add converter method for ip adapters * Move converter method * Update to image proj converter --------- Co-authored-by: Sayak Paul <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes 5915 (comment)
Before submitting
Who can review?
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.
@patrickvonplaten