Skip to content

Conversation

@DN6
Copy link
Collaborator

@DN6 DN6 commented Dec 5, 2023

What does this PR do?

Test Fetcher appears to be working correctly, but I noticed that a bunch of unrelated tests are being fetched for PRs. There are a few imports causing this issue

  1. The diffusers.pipelines.stable_diffusion.convert_from_ckpt is directly imported in the FromSingleFileMixin, triggering all tests for all pipelines using that Mixin whenever the StableDiffusionPipeline is changed.
  2. StableDiffusionPipeline is directly imported into test_pipelines_common.py so all tests importing from this file are also triggered.
  3. A change made to any of the pipelines imported in AutoPipeline also triggers tests for the other pipelines in auto pipeline.

Proposing to pause test fetcher for now until these import issues are resolved.

Fixes # (issue)

Before submitting

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

@DN6 DN6 requested a review from patrickvonplaten December 5, 2023 12:17
@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint.

@DN6 DN6 merged commit 20ba1fd into main Dec 6, 2023
donhardman pushed a commit to donhardman/diffusers that referenced this pull request Dec 18, 2023
AmericanPresidentJimmyCarter pushed a commit to AmericanPresidentJimmyCarter/diffusers that referenced this pull request Apr 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants